]> git.smokeofanarchy.ru Git - space-station-14.git/commit
Random spontaneous cleanup PR (#25131)
authorPieter-Jan Briers <pieterjan.briers+git@gmail.com>
Tue, 13 Feb 2024 21:48:39 +0000 (22:48 +0100)
committerGitHub <noreply@github.com>
Tue, 13 Feb 2024 21:48:39 +0000 (16:48 -0500)
commit68ce53ae17985876d6d112b764b2144964a9f42e
tree61c80042281ffa015db32e0257a9021a1ac49ef8
parentd0c174388c0933c0b90b287bddab43b24d1f58df
Random spontaneous cleanup PR (#25131)

* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>
---------

Co-authored-by: 0x6273 <0x40@keemail.me>
210 files changed:
Content.Benchmarks/ColorInterpolateBenchmark.cs
Content.Benchmarks/Program.cs
Content.Client/Actions/ActionsSystem.cs
Content.Client/Administration/Managers/ClientAdminManager.cs
Content.Client/Administration/UI/SpawnExplosion/SpawnExplosionWindow.xaml.cs
Content.Client/Administration/UI/Tabs/AdminbusTab/LoadBlueprintsWindow.xaml.cs
Content.Client/Administration/UI/Tabs/AtmosTab/AddAtmosWindow.xaml.cs
Content.Client/Administration/UI/Tabs/AtmosTab/AddGasWindow.xaml.cs
Content.Client/Administration/UI/Tabs/AtmosTab/FillGasWindow.xaml.cs
Content.Client/Administration/UI/Tabs/AtmosTab/SetTemperatureWindow.xaml.cs
Content.Client/Alerts/ClientAlertsSystem.cs
Content.Client/Animations/EntityPickupAnimationSystem.cs
Content.Client/Anomaly/Ui/AnomalyGeneratorWindow.xaml.cs
Content.Client/Atmos/Monitor/UI/AirAlarmWindow.xaml.cs
Content.Client/Atmos/Monitor/UI/Widgets/ThresholdBoundControl.xaml
Content.Client/Atmos/Monitor/UI/Widgets/ThresholdBoundControl.xaml.cs
Content.Client/Audio/AmbientSoundSystem.cs
Content.Client/Audio/BackgroundAudioSystem.cs
Content.Client/Audio/ClientGlobalSoundSystem.cs
Content.Client/Audio/ContentAudioSystem.AmbientMusic.cs
Content.Client/Audio/ContentAudioSystem.cs
Content.Client/Camera/CameraRecoilSystem.cs
Content.Client/CardboardBox/CardboardBoxSystem.cs
Content.Client/Cargo/UI/BountyEntry.xaml.cs
Content.Client/Changelog/ChangelogManager.cs
Content.Client/CharacterInfo/CharacterInfoSystem.cs
Content.Client/Chat/TypingIndicator/TypingIndicatorSystem.cs
Content.Client/CloningConsole/UI/CloningConsoleWindow.xaml.cs
Content.Client/CombatMode/CombatModeSystem.cs
Content.Client/Commands/DebugPathfindingCommand.cs
Content.Client/Construction/ConstructionSystem.cs
Content.Client/ContextMenu/UI/EntityMenuUIController.cs
Content.Client/Damage/DamageVisualsSystem.cs
Content.Client/DoAfter/DoAfterSystem.cs
Content.Client/Doors/FirelockSystem.cs
Content.Client/Drugs/DrugOverlaySystem.cs
Content.Client/Drugs/RainbowOverlay.cs
Content.Client/Drunk/DrunkOverlay.cs
Content.Client/Drunk/DrunkSystem.cs
Content.Client/Examine/ExamineSystem.cs
Content.Client/Explosion/ExplosionOverlay.cs
Content.Client/Eye/Blinding/BlindingSystem.cs
Content.Client/Eye/Blinding/BlurryVisionSystem.cs
Content.Client/Eye/EyeLerpingSystem.cs
Content.Client/Flash/FlashOverlay.cs
Content.Client/Flash/FlashSystem.cs
Content.Client/Fluids/PuddleOverlay.cs
Content.Client/Forensics/ForensicScannerMenu.xaml
Content.Client/Forensics/ForensicScannerMenu.xaml.cs
Content.Client/GameTicking/Managers/ClientGameTicker.cs
Content.Client/Gameplay/GameplayStateBase.cs
Content.Client/Ghost/GhostSystem.cs
Content.Client/Gravity/GravitySystem.Shake.cs
Content.Client/Guidebook/GuidebookSystem.cs
Content.Client/Hands/Systems/HandsSystem.cs
Content.Client/HotPotato/HotPotatoSystem.cs
Content.Client/Instruments/InstrumentSystem.cs
Content.Client/Instruments/UI/InstrumentMenu.xaml.cs
Content.Client/Interaction/DragDropSystem.cs
Content.Client/Inventory/StrippableBoundUserInterface.cs
Content.Client/LateJoin/LateJoinGui.cs
Content.Client/MassMedia/Ui/MiniArticleCardControl.xaml
Content.Client/MassMedia/Ui/MiniArticleCardControl.xaml.cs
Content.Client/MassMedia/Ui/NewsWriteMenu.xaml.cs
Content.Client/MouseRotator/MouseRotatorSystem.cs
Content.Client/Movement/Systems/ContentEyeSystem.cs
Content.Client/NetworkConfigurator/Systems/NetworkConfiguratorSystem.cs
Content.Client/Outline/InteractionOutlineSystem.cs
Content.Client/Outline/TargetOutlineSystem.cs
Content.Client/Parallax/ParallaxSystem.cs
Content.Client/Physics/Controllers/MoverController.cs
Content.Client/Players/PlayTimeTracking/JobRequirementsManager.cs
Content.Client/Replay/ContentReplayPlaybackManager.cs
Content.Client/Replay/ReplayConGroup.cs
Content.Client/Research/UI/ResearchConsoleMenu.xaml.cs
Content.Client/Salvage/SalvageSystem.cs
Content.Client/Shuttles/Systems/ShuttleConsoleSystem.cs
Content.Client/Silicons/Laws/Ui/LawDisplay.xaml.cs
Content.Client/Sprite/SpriteFadeSystem.cs
Content.Client/StatusIcon/StatusIconSystem.cs
Content.Client/SubFloor/TrayScannerSystem.cs
Content.Client/Tabletop/TabletopSystem.cs
Content.Client/Traits/ParacusiaSystem.cs
Content.Client/UserInterface/Controls/SplitBar.xaml.cs
Content.Client/UserInterface/Systems/Bwoink/AHelpUIController.cs
Content.Client/UserInterface/Systems/Chat/ChatUIController.cs
Content.Client/UserInterface/Systems/Chat/Widgets/ChatBox.xaml.cs
Content.Client/UserInterface/Systems/DamageOverlays/DamageOverlayUiController.cs
Content.Client/UserInterface/Systems/DamageOverlays/Overlays/DamageOverlay.cs
Content.Client/UserInterface/Systems/Ghost/Controls/Roles/MakeGhostRoleEui.cs
Content.Client/UserInterface/Systems/Viewport/ViewportUIController.cs
Content.Client/Verbs/VerbSystem.cs
Content.Client/Weapons/Melee/MeleeArcOverlay.cs
Content.Client/Weapons/Melee/MeleeWeaponSystem.cs
Content.Client/Weapons/Misc/GrapplingGunSystem.cs
Content.Client/Weapons/Misc/TetherGunSystem.cs
Content.Client/Weapons/Ranged/GunSpreadOverlay.cs
Content.Client/Weapons/Ranged/Systems/FlyBySoundSystem.cs
Content.Client/Weapons/Ranged/Systems/GunSystem.cs
Content.Client/Weather/WeatherSystem.cs
Content.IntegrationTests/Pair/TestPair.Recycle.cs
Content.IntegrationTests/Tests/Actions/ActionsAddedTest.cs
Content.IntegrationTests/Tests/GameObjects/Components/Mobs/AlertsComponentTests.cs
Content.IntegrationTests/Tests/Interaction/InteractionTest.cs
Content.MapRenderer/Painters/GridPainter.cs
Content.MapRenderer/Painters/TilePainter.cs
Content.Server/Access/AccessWireAction.cs
Content.Server/Access/Systems/AccessOverriderSystem.cs
Content.Server/Access/Systems/AgentIDCardSystem.cs
Content.Server/Access/Systems/IdCardSystem.cs
Content.Server/Administration/Commands/BanCommand.cs
Content.Server/Administration/Notes/AdminNotesSystem.cs
Content.Server/Administration/PlayerLocator.cs
Content.Server/Administration/Systems/AdminSystem.cs
Content.Server/Administration/Systems/BwoinkSystem.cs
Content.Server/Administration/UI/PermissionsEui.cs
Content.Server/Administration/UI/SpawnExplosionEui.cs
Content.Server/Afk/AFKSystem.cs
Content.Server/AlertLevel/AlertLevelSystem.cs
Content.Server/AlertLevel/Commands/SetAlertLevelCommand.cs
Content.Server/Ame/AmeNodeGroup.cs
Content.Server/Atmos/EntitySystems/AtmosphereSystem.CVars.cs
Content.Server/Atmos/EntitySystems/GasTileOverlaySystem.cs
Content.Server/Atmos/EntitySystems/HeatExchangerSystem.cs
Content.Server/CartridgeLoader/Cartridges/CrewManifestCartridgeSystem.cs
Content.Server/Chat/Systems/ChatSystem.cs
Content.Server/Chunking/ChunkingSystem.cs
Content.Server/Construction/ConstructionSystem.Initial.cs
Content.Server/Construction/ConstructionSystem.Interactions.cs
Content.Server/Construction/ConstructionSystem.cs
Content.Server/Decals/DecalSystem.cs
Content.Server/Explosion/EntitySystems/ClusterGrenadeSystem.cs
Content.Server/Explosion/EntitySystems/ExplosionSystem.CVars.cs
Content.Server/Explosion/EntitySystems/ExplosionSystem.cs
Content.Server/Explosion/EntitySystems/SmokeOnTriggerSystem.cs
Content.Server/Flash/FlashSystem.cs
Content.Server/GameTicking/GameTicker.CVars.cs
Content.Server/GameTicking/GameTicker.Spawning.cs
Content.Server/Holiday/HolidaySystem.cs
Content.Server/Info/InfoSystem.cs
Content.Server/Info/ShowRulesCommand.cs
Content.Server/Instruments/InstrumentSystem.CVars.cs
Content.Server/Instruments/InstrumentSystem.cs
Content.Server/Light/EntitySystems/PoweredLightSystem.cs
Content.Server/Mapping/MappingSystem.cs
Content.Server/MassMedia/Systems/NewsSystem.cs
Content.Server/Mind/MindSystem.cs
Content.Server/Motd/MOTDSystem.cs
Content.Server/NPC/Systems/NPCCombatSystem.Melee.cs
Content.Server/NPC/Systems/NPCSteeringSystem.cs
Content.Server/NPC/Systems/NPCSystem.cs
Content.Server/Objectives/Systems/ObjectiveLimitSystem.cs
Content.Server/PDA/Ringer/RingerSystem.cs
Content.Server/Parallax/BiomeSystem.cs
Content.Server/Pinpointer/PinpointerSystem.cs
Content.Server/Radiation/Systems/RadiationSystem.Cvar.cs
Content.Server/Radiation/Systems/RadiationSystem.cs
Content.Server/RandomAppearance/RandomAppearanceComponent.cs
Content.Server/Salvage/SalvageSystem.Expeditions.cs
Content.Server/Salvage/SalvageSystem.cs
Content.Server/Shuttles/Systems/ArrivalsSystem.cs
Content.Server/Shuttles/Systems/EmergencyShuttleSystem.Console.cs
Content.Server/Shuttles/Systems/EmergencyShuttleSystem.cs
Content.Server/Shuttles/Systems/ShuttleSystem.GridFill.cs
Content.Server/Shuttles/Systems/ShuttleSystem.cs
Content.Server/Station/Systems/StationJobsSystem.cs
Content.Server/Station/Systems/StationSpawningSystem.cs
Content.Server/Station/Systems/StationSystem.cs
Content.Server/StationEvents/EventManagerSystem.cs
Content.Server/Storage/EntitySystems/CursedEntityStorageSystem.cs
Content.Server/Store/Conditions/BuyerSpeciesCondition.cs
Content.Server/Tips/TipsSystem.cs
Content.Server/UserInterface/ActivatableUIComponent.cs
Content.Server/Worldgen/Systems/WorldgenConfigSystem.cs
Content.Shared/Access/Systems/SharedAccessSystem.cs
Content.Shared/Actions/SharedActionsSystem.cs
Content.Shared/Alert/AlertPrototype.cs
Content.Shared/Anomaly/Effects/SharedGravityAnomalySystem.cs
Content.Shared/Anomaly/SharedAnomalySystem.cs
Content.Shared/Bed/Cryostorage/SharedCryostorageSystem.cs
Content.Shared/Bed/Sleep/SharedSleepingSystem.cs
Content.Shared/Blocking/BlockingSystem.cs
Content.Shared/CartridgeLoader/SharedCartridgeLoaderSystem.cs
Content.Shared/Charges/Systems/SharedChargesSystem.cs
Content.Shared/Clothing/EntitySystems/StealthClothingSystem.cs
Content.Shared/Construction/SharedFlatpackSystem.cs
Content.Shared/Damage/Systems/DamageableSystem.cs
Content.Shared/Damage/Systems/PassiveDamageSystem.cs
Content.Shared/Doors/Systems/SharedDoorSystem.cs
Content.Shared/Examine/ExamineSystemShared.cs
Content.Shared/Explosion/Components/OnTrigger/SmokeOnTriggerComponent.cs
Content.Shared/Eye/Blinding/Systems/BlurryVisionSystem.cs
Content.Shared/Fluids/SharedDrainSystem.cs
Content.Shared/Friction/TileFrictionController.cs
Content.Shared/Gibbing/Systems/GibbingSystem.cs
Content.Shared/Hands/EntitySystems/SharedHandsSystem.cs
Content.Shared/Inventory/InventorySystem.Slots.cs
Content.Shared/Movement/Systems/SharedMoverController.Input.cs
Content.Shared/Movement/Systems/SharedMoverController.Relay.cs
Content.Shared/Movement/Systems/SharedMoverController.cs
Content.Shared/Pinpointer/SharedPinpointerSystem.cs
Content.Shared/Placeable/ItemPlacerSystem.cs
Content.Shared/Power/Generator/ActiveGeneratorRevvingSystem.cs
Content.Shared/RCD/Systems/RCDSystem.cs
Content.Shared/Spider/SharedSpiderSystem.cs
Content.Shared/SprayPainter/SharedSprayPainterSystem.cs
Content.Shared/Stealth/SharedStealthSystem.cs
Content.Shared/Storage/EntitySystems/DumpableSystem.cs
Content.Shared/Tiles/FloorTileSystem.cs
Content.Shared/UserInterface/OpenUiActionEvent.cs