]> git.smokeofanarchy.ru Git - space-station-14.git/commit
Fix sinks and toilets not draining (#33691)
authorPartmedia <kevinz5000@gmail.com>
Wed, 4 Dec 2024 02:42:16 +0000 (18:42 -0800)
committerGitHub <noreply@github.com>
Wed, 4 Dec 2024 02:42:16 +0000 (03:42 +0100)
commitcf202e805dd998f5e1f0865000f02bdf029812f7
tree76b180b38fe6b5d38a1e61b3544d37bbef78954f
parent87182635b61ec7f47adc0855e4c57a887338fbdf
Fix sinks and toilets not draining (#33691)

* Fix AutoDrain

Per the system comments, AutoDrain is designed to automatically move
puddles into the drain (like a floor drain). Drains without AutoDrain
are still supposed to gradually empty the buffer, but not remove puddles
(like sinks and toilets).

However, a logic error in the original implementation causes drains with
AutoDrain set to false to simply not work. Hence sinks never emptied.

* Update documentation
Content.Server/Fluids/EntitySystems/DrainSystem.cs
Content.Shared/Fluids/Components/DrainComponent.cs