Change Polymorph Actions to use Polymorph Proto Id (#26419)

* polymorph changes

Adds poly proto ids to polymorph action event and checks for proto id when performing

* nullable proto id

* Replaces instances of Polymorph prototype with a proto id and tryindex

* birdup

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>

diff --git a/Content.Server/Polymorph/Systems/PolymorphSystem.cs b/Content.Server/Polymorph/Systems/PolymorphSystem.cs
index 5fe29dcd30e28c441afb7d3fb71cd558fd68238e..b7640ff984358f01c50dbd9db4aaabfa7f7b1de6 100644 (file)
--- a/Content.Server/Polymorph/Systems/PolymorphSystem.cs
+++ b/Content.Server/Polymorph/Systems/PolymorphSystem.cs
@@ -118,7 +118,10 @@ public sealed partial class PolymorphSystem : EntitySystem
 
     private void OnPolymorphActionEvent(Entity<PolymorphableComponent> ent, ref PolymorphActionEvent args)
     {
-        PolymorphEntity(ent, args.Prototype.Configuration);
+        if (!_proto.TryIndex(args.ProtoId, out var prototype))
+            return;
+
+        PolymorphEntity(ent, prototype.Configuration);
     }
 
     private void OnRevertPolymorphActionEvent(Entity<PolymorphedEntityComponent> ent,
@@ -348,7 +351,9 @@ public sealed partial class PolymorphSystem : EntitySystem
         if (target.Comp.PolymorphActions.ContainsKey(id))
             return;
 
-        var polyProto = _proto.Index(id);
+        if (!_proto.TryIndex(id, out var polyProto))
+            return;
+
         var entProto = _proto.Index(polyProto.Configuration.Entity);
 
         EntityUid? actionId = default!;
@@ -366,7 +371,7 @@ public sealed partial class PolymorphSystem : EntitySystem
 
         baseAction.Icon = new SpriteSpecifier.EntityPrototype(polyProto.Configuration.Entity);
         if (baseAction is InstantActionComponent action)
-            action.Event = new PolymorphActionEvent(prototype: polyProto);
+            action.Event = new PolymorphActionEvent(id);
     }
 
     public void RemovePolymorphAction(ProtoId<PolymorphPrototype> id, Entity<PolymorphableComponent> target)

diff --git a/Content.Server/Polymorph/Toolshed/PolymorphCommand.cs b/Content.Server/Polymorph/Toolshed/PolymorphCommand.cs
index f741c24571e54c2bbdaecb908da1b4cf6e128bc9..5654c84722f7a3b27f89e1e0a55a4ce2d6a148af 100644 (file)
--- a/Content.Server/Polymorph/Toolshed/PolymorphCommand.cs
+++ b/Content.Server/Polymorph/Toolshed/PolymorphCommand.cs
@@ -3,8 +3,8 @@ using Content.Server.Administration;
 using Content.Server.Polymorph.Systems;
 using Content.Shared.Administration;
 using Content.Shared.Polymorph;
+using Robust.Shared.Prototypes;
 using Robust.Shared.Toolshed;
-using Robust.Shared.Toolshed.TypeParsers;
 
 namespace Content.Server.Polymorph.Toolshed;
 
@@ -15,22 +15,26 @@ namespace Content.Server.Polymorph.Toolshed;
 public sealed class PolymorphCommand : ToolshedCommand
 {
     private PolymorphSystem? _system;
+    [Dependency] private IPrototypeManager _proto = default!;
 
     [CommandImplementation]
     public EntityUid? Polymorph(
             [PipedArgument] EntityUid input,
-            [CommandArgument] Prototype<PolymorphPrototype> prototype
+            [CommandArgument] ProtoId<PolymorphPrototype> protoId
         )
     {
         _system ??= GetSys<PolymorphSystem>();
 
-        return _system.PolymorphEntity(input, prototype.Value.Configuration);
+        if (!_proto.TryIndex(protoId, out var prototype))
+            return null;
+
+        return _system.PolymorphEntity(input, prototype.Configuration);
     }
 
     [CommandImplementation]
     public IEnumerable<EntityUid> Polymorph(
             [PipedArgument] IEnumerable<EntityUid> input,
-            [CommandArgument] Prototype<PolymorphPrototype> prototype
+            [CommandArgument] ProtoId<PolymorphPrototype> protoId
         )
-        => input.Select(x => Polymorph(x, prototype)).Where(x => x is not null).Select(x => (EntityUid)x!);
+        => input.Select(x => Polymorph(x, protoId)).Where(x => x is not null).Select(x => (EntityUid)x!);
 }

diff --git a/Content.Shared/Polymorph/PolymorphActions.cs b/Content.Shared/Polymorph/PolymorphActions.cs
index 0f230868f03fb38f1662f4f8248626d83bac91f0..13e00f55e2bb8c97dbec9136bb67c67eaa518421 100644 (file)
--- a/Content.Shared/Polymorph/PolymorphActions.cs
+++ b/Content.Shared/Polymorph/PolymorphActions.cs
@@ -1,18 +1,20 @@
 using Content.Shared.Actions;
+using Robust.Shared.Prototypes;
 
 namespace Content.Shared.Polymorph;
 
 public sealed partial class PolymorphActionEvent : InstantActionEvent
 {
     /// <summary>
-    /// The polymorph prototype containing all the information about
-    /// the specific polymorph.
+    ///     The polymorph proto id, containing all the information about
+    ///     the specific polymorph.
     /// </summary>
-    public PolymorphPrototype Prototype = default!;
+    [DataField]
+    public ProtoId<PolymorphPrototype>? ProtoId;
 
-    public PolymorphActionEvent(PolymorphPrototype prototype) : this()
+    public PolymorphActionEvent(ProtoId<PolymorphPrototype> protoId) : this()
     {
-        Prototype = prototype;
+        ProtoId = protoId;
     }
 }