]> git.smokeofanarchy.ru Git - space-station-14.git/commitdiff
Remove cloneData parameter from AutoNetworkedField (#20596)
authorDrSmugleaf <DrSmugleaf@users.noreply.github.com>
Sat, 30 Sep 2023 05:14:16 +0000 (22:14 -0700)
committerGitHub <noreply@github.com>
Sat, 30 Sep 2023 05:14:16 +0000 (15:14 +1000)
Content.Shared/Access/Components/AccessComponent.cs
Content.Shared/Access/Components/AccessOverriderComponent.cs
Content.Shared/Body/Part/BodyPartComponent.cs
Content.Shared/Buckle/Components/StrapComponent.cs
Content.Shared/Humanoid/HumanoidAppearanceComponent.cs
Content.Shared/Nutrition/Components/HungerComponent.cs
Content.Shared/Nutrition/Components/ThirstComponent.cs
Content.Shared/Points/PointManagerComponent.cs
Content.Shared/Research/Components/TechnologyDatabaseComponent.cs
Content.Shared/Standing/StandingStateComponent.cs
Content.Shared/StepTrigger/Components/StepTriggerComponent.cs

index 35521d23db4ab3dce109137d220cd1da16c20a63..6930f2dfd60129cda43766c1a686785ce3b1b7ad 100644 (file)
@@ -22,14 +22,14 @@ namespace Content.Shared.Access.Components
 
         [DataField("tags", customTypeSerializer: typeof(PrototypeIdHashSetSerializer<AccessLevelPrototype>))]
         [Access(typeof(SharedAccessSystem), Other = AccessPermissions.ReadExecute)] // FIXME Friends
-        [AutoNetworkedField(true)]
+        [AutoNetworkedField]
         public HashSet<string> Tags = new();
 
         /// <summary>
         ///     Access Groups. These are added to the tags during map init. After map init this will have no effect.
         /// </summary>
         [DataField("groups", readOnly: true, customTypeSerializer: typeof(PrototypeIdHashSetSerializer<AccessGroupPrototype>))]
-        [AutoNetworkedField(true)]
+        [AutoNetworkedField]
         public HashSet<string> Groups = new();
     }
 
index 4e1a376ab625167048163926e4b65871fd4fe5f1..92c09f1ab7178181675b3e1d40bf83ed6c8b3a0b 100644 (file)
@@ -33,7 +33,7 @@ public sealed partial class AccessOverriderComponent : Component
         }
     }
 
-    [DataField, AutoNetworkedField(true)]
+    [DataField, AutoNetworkedField]
     public List<ProtoId<AccessLevelPrototype>> AccessLevels = new();
 
     [ViewVariables(VVAccess.ReadWrite)]
index cbbfef4d73e119da7b9f98ec8b4d4b6d5cdae17c..4f838d989838645ba8458f253bffde5113e140c0 100644 (file)
@@ -34,13 +34,13 @@ public sealed partial class BodyPartComponent : Component
     /// <summary>
     /// Child body parts attached to this body part.
     /// </summary>
-    [DataField, AutoNetworkedField(CloneData = true)]
+    [DataField, AutoNetworkedField]
     public Dictionary<string, BodyPartSlot> Children = new();
 
     /// <summary>
     /// Organs attached to this body part.
     /// </summary>
-    [DataField, AutoNetworkedField(CloneData = true)]
+    [DataField, AutoNetworkedField]
     public Dictionary<string, OrganSlot> Organs = new();
 
     /// <summary>
index 4efe154797c80adf857db18fefad92f04487c5a4..46f260741a73c725beed64e9b0a848fd64687f0b 100644 (file)
@@ -15,7 +15,7 @@ public sealed partial class StrapComponent : Component
     /// <summary>
     /// The entities that are currently buckled
     /// </summary>
-    [AutoNetworkedField(true)]
+    [AutoNetworkedField]
     [ViewVariables] // TODO serialization
     public HashSet<EntityUid> BuckledEntities = new();
 
index bd7eef34bcc1f4f0626782789aa059fbe91f1245..82d6964522ca3dfa313deb25079804ff49ef4fa8 100644 (file)
@@ -19,7 +19,7 @@ public sealed partial class HumanoidAppearanceComponent : Component
     [DataField]
     public Dictionary<HumanoidVisualLayers, HumanoidSpeciesSpriteLayer> BaseLayers = new();
 
-    [DataField, AutoNetworkedField(true)]
+    [DataField, AutoNetworkedField]
     public HashSet<HumanoidVisualLayers> PermanentlyHidden = new();
 
     // Couldn't these be somewhere else?
@@ -36,7 +36,7 @@ public sealed partial class HumanoidAppearanceComponent : Component
     ///     Stored on the server, this is merged in the client into
     ///     all layer settings.
     /// </summary>
-    [DataField, AutoNetworkedField(true)]
+    [DataField, AutoNetworkedField]
     public Dictionary<HumanoidVisualLayers, CustomBaseLayerInfo> CustomBaseLayers = new();
 
     /// <summary>
@@ -62,7 +62,7 @@ public sealed partial class HumanoidAppearanceComponent : Component
     ///     Visual layers currently hidden. This will affect the base sprite
     ///     on this humanoid layer, and any markings that sit above it.
     /// </summary>
-    [DataField, AutoNetworkedField(true)]
+    [DataField, AutoNetworkedField]
     public HashSet<HumanoidVisualLayers> HiddenLayers = new();
 
     [DataField, AutoNetworkedField]
index 037c069cf4dc76d9a9d486985e6fc53149ca9d99..11197d8b42a44013bf7bf631b66654af31c93cac 100644 (file)
@@ -52,7 +52,7 @@ public sealed partial class HungerComponent : Component
     /// A dictionary relating HungerThreshold to the amount of <see cref="CurrentHunger"/> needed for each one
     /// </summary>
     [DataField("thresholds", customTypeSerializer: typeof(DictionarySerializer<HungerThreshold, float>))]
-    [AutoNetworkedField(cloneData: true)]
+    [AutoNetworkedField]
     public Dictionary<HungerThreshold, float> Thresholds = new()
     {
         { HungerThreshold.Overfed, 200.0f },
@@ -66,7 +66,7 @@ public sealed partial class HungerComponent : Component
     /// A dictionary relating hunger thresholds to corresponding alerts.
     /// </summary>
     [DataField("hungerThresholdAlerts", customTypeSerializer: typeof(DictionarySerializer<HungerThreshold, AlertType>))]
-    [AutoNetworkedField(cloneData: true)]
+    [AutoNetworkedField]
     public Dictionary<HungerThreshold, AlertType> HungerThresholdAlerts = new()
     {
         { HungerThreshold.Peckish, AlertType.Peckish },
@@ -78,7 +78,7 @@ public sealed partial class HungerComponent : Component
     /// A dictionary relating HungerThreshold to how much they modify <see cref="BaseDecayRate"/>.
     /// </summary>
     [DataField("hungerThresholdDecayModifiers", customTypeSerializer: typeof(DictionarySerializer<HungerThreshold, float>))]
-    [AutoNetworkedField(cloneData: true)]
+    [AutoNetworkedField]
     public Dictionary<HungerThreshold, float> HungerThresholdDecayModifiers = new()
     {
         { HungerThreshold.Overfed, 1.2f },
index 994361470ac2b10cfb58be5b6f6291560328378f..1e3f1398079da658d3b761486577710426999466 100644 (file)
@@ -45,7 +45,7 @@ public sealed partial class ThirstComponent : Component
     public TimeSpan UpdateRate = TimeSpan.FromSeconds(1);
 
     [DataField("thresholds")]
-    [AutoNetworkedField(cloneData: true)]
+    [AutoNetworkedField]
     public Dictionary<ThirstThreshold, float> ThirstThresholds = new()
     {
         {ThirstThreshold.OverHydrated, 600.0f},
index 91dfef6a4e30b4a190a32bbddc6f58e5193c7588..6c5bf6b0fa3ca7a7549a8df04de7178a6c99be10 100644 (file)
@@ -15,7 +15,7 @@ public sealed partial class PointManagerComponent : Component
     /// <summary>
     /// A dictionary of a player's netuserID to the amount of points they have.
     /// </summary>
-    [DataField, AutoNetworkedField(true)]
+    [DataField, AutoNetworkedField]
     public Dictionary<NetUserId, FixedPoint2> Points = new();
 
     /// <summary>
index b9936956adc85249c2a7a5de6a7568149de3035f..fc317454c9a3f2fbe374efd1461a8745ff04be23 100644 (file)
@@ -17,21 +17,21 @@ public sealed partial class TechnologyDatabaseComponent : Component
     [DataField("mainDiscipline", customTypeSerializer: typeof(PrototypeIdSerializer<TechDisciplinePrototype>))]
     public string? MainDiscipline;
 
-    [AutoNetworkedField(true)]
+    [AutoNetworkedField]
     [DataField("currentTechnologyCards")]
     public List<string> CurrentTechnologyCards = new();
 
     /// <summary>
     /// Which research disciplines are able to be unlocked
     /// </summary>
-    [AutoNetworkedField(true)]
+    [AutoNetworkedField]
     [DataField("supportedDisciplines", customTypeSerializer: typeof(PrototypeIdListSerializer<TechDisciplinePrototype>))]
     public List<string> SupportedDisciplines = new();
 
     /// <summary>
     /// The ids of all the technologies which have been unlocked.
     /// </summary>
-    [AutoNetworkedField(true)]
+    [AutoNetworkedField]
     [DataField("unlockedTechnologies", customTypeSerializer: typeof(PrototypeIdListSerializer<TechnologyPrototype>))]
     public List<string> UnlockedTechnologies = new();
 
@@ -40,7 +40,7 @@ public sealed partial class TechnologyDatabaseComponent : Component
     /// This is maintained alongside the TechnologyIds
     /// </summary>
     /// todo: if you unlock all the recipes in a tech, it doesn't count as unlocking the tech. sadge
-    [AutoNetworkedField(true)]
+    [AutoNetworkedField]
     [DataField("unlockedRecipes", customTypeSerializer: typeof(PrototypeIdListSerializer<LatheRecipePrototype>))]
     public List<string> UnlockedRecipes = new();
 }
index b1ec6d8668b3aa90e2eb319b0f66e223641dad33..5d7bb0a59fdb6817f30f4e18953168c838bf5692 100644 (file)
@@ -18,7 +18,7 @@ namespace Content.Shared.Standing
         ///     List of fixtures that had their collision mask changed when the entity was downed.
         ///     Required for re-adding the collision mask.
         /// </summary>
-        [DataField, AutoNetworkedField(true)]
+        [DataField, AutoNetworkedField]
         public List<string> ChangedFixtures = new();
     }
 }
index c4457179a9799bb62d3010675b5bee2e59c033b8..f4731bf46abd12c885bc6605950dc6b8e3c8463a 100644 (file)
@@ -11,14 +11,14 @@ public sealed partial class StepTriggerComponent : Component
     /// <summary>
     ///     List of entities that are currently colliding with the entity.
     /// </summary>
-    [ViewVariables, AutoNetworkedField(true)]
+    [ViewVariables, AutoNetworkedField]
     public HashSet<EntityUid> Colliding = new();
 
     /// <summary>
     ///     The list of entities that are standing on this entity,
     /// which shouldn't be able to trigger it again until stepping off.
     /// </summary>
-    [ViewVariables, AutoNetworkedField(true)]
+    [ViewVariables, AutoNetworkedField]
     public HashSet<EntityUid> CurrentlySteppedOn = new();
 
     /// <summary>