Replaces reagent-effect-guidebook-missing with more descriptive guidebook entries...

removes `reagent-effect-guidebook-missing`

Co-authored-by: John Doe <johndoe@gmail.com>

diff --git a/Content.Server/Chemistry/ReactionEffects/AreaReactionEffect.cs b/Content.Server/Chemistry/ReactionEffects/AreaReactionEffect.cs
index ebbf4e0341b29032519d05bbe9f6dba0802b3ffd..56509a0953eb09b20b0873ba1cbdb737b5e4db7d 100644 (file)
--- a/Content.Server/Chemistry/ReactionEffects/AreaReactionEffect.cs
+++ b/Content.Server/Chemistry/ReactionEffects/AreaReactionEffect.cs
@@ -46,7 +46,9 @@ namespace Content.Server.Chemistry.ReactionEffects
         public override bool ShouldLog => true;
 
         protected override string ReagentEffectGuidebookText(IPrototypeManager prototype, IEntitySystemManager entSys)
-            => Loc.GetString("reagent-effect-guidebook-missing");
+            => Loc.GetString("reagent-effect-guidebook-area-reaction",
+                    ("duration", _duration)
+                );
 
         public override LogImpact LogImpact => LogImpact.High;
 

diff --git a/Content.Server/Chemistry/ReagentEffects/AddToSolutionReaction.cs b/Content.Server/Chemistry/ReagentEffects/AddToSolutionReaction.cs
index 6a43739b0ee2dacbc0970af91c24557c07d8dd96..2447814f948f5659f750daf24d7b9230df9524ae 100644 (file)
--- a/Content.Server/Chemistry/ReagentEffects/AddToSolutionReaction.cs
+++ b/Content.Server/Chemistry/ReagentEffects/AddToSolutionReaction.cs
@@ -26,6 +26,6 @@ namespace Content.Server.Chemistry.ReagentEffects
         }
 
         protected override string? ReagentEffectGuidebookText(IPrototypeManager prototype, IEntitySystemManager entSys) =>
-            Loc.GetString("reagent-effect-guidebook-missing", ("chance", Probability));
+            Loc.GetString("reagent-effect-guidebook-add-to-solution-reaction", ("chance", Probability));
     }
 }

diff --git a/Content.Shared/Chemistry/Reagent/ReagentEffect.cs b/Content.Shared/Chemistry/Reagent/ReagentEffect.cs
index 5bcb21fedb30b4d576f37e528837ae00be168f53..6d0e85df37995cc492c8fc394487670986cbb8be 100644 (file)
--- a/Content.Shared/Chemistry/Reagent/ReagentEffect.cs
+++ b/Content.Shared/Chemistry/Reagent/ReagentEffect.cs
@@ -1,4 +1,4 @@
-using System.Linq;
+using System.Linq;
 using System.Text.Json.Serialization;
 using Content.Shared.Chemistry.Components;
 using Content.Shared.Database;
@@ -28,7 +28,7 @@ namespace Content.Shared.Chemistry.Reagent
 
         public virtual string ReagentEffectFormat => "guidebook-reagent-effect-description";
 
-        protected abstract string? ReagentEffectGuidebookText(IPrototypeManager prototype, IEntitySystemManager entSys); // => Loc.GetString("reagent-effect-guidebook-missing", ("chance", Probability));
+        protected abstract string? ReagentEffectGuidebookText(IPrototypeManager prototype, IEntitySystemManager entSys);
 
         /// <summary>
         ///     What's the chance, from 0 to 1, that this effect will occur?

diff --git a/Resources/Locale/en-US/guidebook/chemistry/effects.ftl b/Resources/Locale/en-US/guidebook/chemistry/effects.ftl
index ba005e6bf98350b3c186b8e74152bf4f5da018e8..c60e690d26733464b9a2d29d6d2f5cc70ac9a720 100644 (file)
--- a/Resources/Locale/en-US/guidebook/chemistry/effects.ftl
+++ b/Resources/Locale/en-US/guidebook/chemistry/effects.ftl
@@ -1,4 +1,4 @@
--create-3rd-person =
+-create-3rd-person =
     { $chance ->
         [1] Creates
         *[other] create
@@ -345,11 +345,17 @@ reagent-effect-guidebook-reduce-rotting =
         *[other] regenerate
     } {NATURALFIXED($time, 3)} {MANY("second", $time)} of rotting
 
-reagent-effect-guidebook-missing =
+reagent-effect-guidebook-area-reaction =
     { $chance ->
         [1] Causes
         *[other] cause
-    } an unknown effect as nobody has written this effect yet
+    } a smoke or foam reaction for {NATURALFIXED($duration, 3)} {MANY("second", $duration)}
+
+reagent-effect-guidebook-add-to-solution-reaction =
+    { $chance ->
+        [1] Causes
+        *[other] cause
+    } chemicals applied to an object to be added to its internal solution container
 
 reagent-effect-guidebook-plant-attribute =
     { $chance ->