Fix windoor prototypes (#16224)

diff --git a/Content.IntegrationTests/Tests/PrototypeSaveTest.cs b/Content.IntegrationTests/Tests/PrototypeSaveTest.cs
index 15a1080967702bc59d5fb6823488ec4795879a3d..7881b624e93ad9603edb4afed038a7994dcbd729 100644 (file)
--- a/Content.IntegrationTests/Tests/PrototypeSaveTest.cs
+++ b/Content.IntegrationTests/Tests/PrototypeSaveTest.cs
@@ -28,7 +28,7 @@ namespace Content.IntegrationTests.Tests;
 ///     modified during init. I.e., when the entity is saved to the map, its data is simply the default prototype data (ignoring transform component).
 /// </summary>
 /// <remarks>
-///     If you are here becaus your test is failing, one easy way of figuring out how to fix the prototype is to just
+///     If you are here because this test is failing on your PR, then one easy way of figuring out how to fix the prototype is to just
 ///     spawn it into a new empty map and seeing what the map yml looks like.
 /// </remarks>
 [TestFixture]
@@ -38,57 +38,8 @@ public sealed class PrototypeSaveTest
     {
         "Singularity", // physics collision uses "AllMask" (-1). The flag serializer currently fails to save this because this features un-named bits.
         "constructionghost",
-        // URGH door pr but I just don't
-        "BlastDoorBridgeOpen",
-        "Windoor",
-        "WindoorSecure",
-        "WindoorSecureCargoLocked",
-        "WindoorTheatreLocked",
-        "BlastDoorBridge",
-        "WindoorSecureJanitorLocked",
-        "ShuttersWindow",
-        "WindoorScienceLocked",
-        "WindoorJanitorLocked",
-        "WindoorEngineeringLocked",
-        "BlastDoorExterior2",
-        "WindoorChemistryLocked",
-        "BlastDoorExterior3",
-        "WindoorMedicalLocked",
-        "ShuttersNormalOpen",
-        "WindoorBarKitchenLocked",
-        "BlastDoorOpen",
-        "ShuttersRadiationOpen",
-        "BlastDoorWindowsOpen",
-        "WindoorBarLocked",
-        "WindoorChapelLocked",
-        "WindoorArmoryLocked",
-        "BlastDoorExterior3Open",
-        "WindoorCargoLocked",
-        "WindoorSecurityLocked",
-        "WindoorExternalLocked",
-        "WindoorBrigLocked",
-        "WindoorHydroponicsLocked",
-        "ShuttersWindowOpen",
-        "WindoorKitchenHydroponicsLocked",
-        "WindoorSecureChapelLocked",
-        "BlastDoorExterior1Open",
-        "WindoorKitchenLocked",
-        "BlastDoor",
-        "BlastDoorWindows",
-        "BlastDoorExterior1",
-        "BlastDoorExterior2Open",
-        "WindoorSecureKitchenLocked",
-        "WindoorHeadOfPersonnelLocked",
-        "ShuttersRadiation",
-        "ShuttersNormal",
-        "WindoorSecureSalvageLocked",
-        "WindoorServiceLocked",
-        "WindoorCommandLocked",
-        "AirlockMaintMedLocked",
-        "AirlockArmoryGlassLocked",
-        "AirlockExternalGlassLocked",
-        "AirlockFreezerKitchenHydroLocked",
-        "AirlockGlassShuttle",
+        // Don't add to this list unless you have a good reason
+        // Or it is just temporary because tests stopped working and now master has too many broken entities.
     };
 
     [Test]

diff --git a/Resources/Prototypes/Entities/Structures/Doors/Shutter/shutters.yml b/Resources/Prototypes/Entities/Structures/Doors/Shutter/shutters.yml
index 5cdbfe848a77674f6acf23ea3304deb14443fce3..94ca4d9291d0136c345b4886777eb2633c9b2223 100644 (file)
--- a/Resources/Prototypes/Entities/Structures/Doors/Shutter/shutters.yml
+++ b/Resources/Prototypes/Entities/Structures/Doors/Shutter/shutters.yml
@@ -86,6 +86,9 @@
       - Open
       - Close
       - Toggle
+  - type: DeviceLinkSource
+    ports:
+    - DoorStatus
   - type: InteractionPopup
     interactSuccessString: comp-window-knock
     messagePerceivedByOthers: comp-window-knock

diff --git a/Resources/Prototypes/Entities/Structures/Doors/Windoors/base_structurewindoors.yml b/Resources/Prototypes/Entities/Structures/Doors/Windoors/base_structurewindoors.yml
index 192f6202a103f593d7e0f63d376416c043c97af5..2f6bed7e351bd98efa38c380d267bd1350744624 100644 (file)
--- a/Resources/Prototypes/Entities/Structures/Doors/Windoors/base_structurewindoors.yml
+++ b/Resources/Prototypes/Entities/Structures/Doors/Windoors/base_structurewindoors.yml
@@ -57,6 +57,9 @@
       - Close
       - Toggle
       - AutoClose
+  - type: DeviceLinkSource
+    ports:
+    - DoorStatus
   - type: Damageable
     damageContainer: Inorganic
     damageModifierSet: Glass