]> git.smokeofanarchy.ru Git - space-station-14.git/commitdiff
Entity effects warnings cleanup (#36166)
authorJ <billsmith116@gmail.com>
Mon, 14 Apr 2025 03:58:53 +0000 (03:58 +0000)
committerGitHub <noreply@github.com>
Mon, 14 Apr 2025 03:58:53 +0000 (13:58 +1000)
Content.Server/EntityEffects/Effects/AreaReactionEffect.cs
Content.Server/EntityEffects/Effects/MovespeedModifier.cs

index 858da2b360569d5d27bbdf4d2c9a8aebf5741b0f..ce06705b2b8f862c55b158f949eac1b256109498 100644 (file)
@@ -85,7 +85,7 @@ public sealed partial class AreaReactionEffect : EntityEffect
             smoke.StartSmoke(ent, splitSolution, _duration, spreadAmount);
 
             var audio = reagentArgs.EntityManager.System<SharedAudioSystem>();
-            audio.PlayPvs(_sound, reagentArgs.TargetEntity, AudioHelpers.WithVariation(0.125f));
+            audio.PlayPvs(_sound, reagentArgs.TargetEntity, AudioParams.Default.WithVariation(0.25f));
             return;
         }
 
index ac1f143e9fb435627535d3674f04a8361654e56b..74f4489c75feba695b3b96f4a42627426af7c2af 100644 (file)
@@ -61,18 +61,19 @@ public sealed partial class MovespeedModifier : EntityEffect
             statusLifetime *= reagentArgs.Scale.Float();
         }
 
-        IncreaseTimer(status, statusLifetime);
+        IncreaseTimer(status, statusLifetime, args.EntityManager, args.TargetEntity);
 
         if (modified)
             args.EntityManager.System<MovementSpeedModifierSystem>().RefreshMovementSpeedModifiers(args.TargetEntity);
     }
-    public void IncreaseTimer(MovespeedModifierMetabolismComponent status, float time)
+    private void IncreaseTimer(MovespeedModifierMetabolismComponent status, float time, IEntityManager entityManager, EntityUid uid)
     {
         var gameTiming = IoCManager.Resolve<IGameTiming>();
 
         var offsetTime = Math.Max(status.ModifierTimer.TotalSeconds, gameTiming.CurTime.TotalSeconds);
 
         status.ModifierTimer = TimeSpan.FromSeconds(offsetTime + time);
-        status.Dirty();
+
+        entityManager.Dirty(uid, status);
     }
 }