feat: make ReagentId hash by value (#39494)

diff --git a/Content.Shared/Chemistry/Reagent/ReagentId.cs b/Content.Shared/Chemistry/Reagent/ReagentId.cs
index 798dd28db490aeab83ad55dc8308f04804795b35..88c0abff2a5ac8125f4fe3d0b1aff64b7964f9ad 100644 (file)
--- a/Content.Shared/Chemistry/Reagent/ReagentId.cs
+++ b/Content.Shared/Chemistry/Reagent/ReagentId.cs
@@ -75,7 +75,21 @@ public partial struct ReagentId : IEquatable<ReagentId>
 
     public override int GetHashCode()
     {
-        return HashCode.Combine(Prototype, Data);
+        // We need to make sure we take the hash code of Data by value in order
+        // for hashed key lookups to work properly
+        var hash = 17;
+        unchecked
+        {
+            if (Data?.Count != 0)
+            {
+                foreach (var data in Data ?? [])
+                {
+                    hash = hash * 23 + data.GetHashCode();
+                }
+            }
+        }
+
+        return HashCode.Combine(Prototype, hash);
     }
 
     public string ToString(FixedPoint2 quantity)