Fix: LockSystem - HasUserAccess - Set DenyReason Localization Text Properly (#41012)

* Update AccessReaderSystem.cs

Fixes #40987
Related to PR #40883

Set DenyReason in CheckUserHasLockAccessEvent when access is denied to display "Access denied." popup to users. Uses ??= to avoid overriding reasons from possible systems.

* RE-FIX: Localize default deny reason in LockSystem.HasUserAccess

The default deny reason was being passed as a localization key string instead of being localized before display.

* Re-added null coalescing operator

Per maint request

diff --git a/Content.Shared/Lock/LockSystem.cs b/Content.Shared/Lock/LockSystem.cs
index ca780780fb53d0335210f397a1b921db0c48c2b1..95a681dc38971addf4492d56e1f3d36fe9ab3423 100644 (file)
--- a/Content.Shared/Lock/LockSystem.cs
+++ b/Content.Shared/Lock/LockSystem.cs
@@ -351,7 +351,7 @@ public sealed class LockSystem : EntitySystem
 
         if (!quiet)
         {
-            var denyReason = accessEv.DenyReason ?? _defaultDenyReason;
+            var denyReason = accessEv.DenyReason ?? Loc.GetString(_defaultDenyReason);
             _sharedPopupSystem.PopupClient(denyReason, ent, user);
         }