{
"Singularity", // physics collision uses "AllMask" (-1). The flag serializer currently fails to save this because this features un-named bits.
"constructionghost",
-
- // These ones are from the serialization change to alwayswrite.
- // These should NOT be added to.
- // 99% of these are going to be changing the physics bodytype (where the entity is anchored)
- // or some ambientsound change.
- "GasVentScrubber",
- "GasPassiveVent",
- "CableHV",
- "ParticleAcceleratorFuelChamberUnfinished",
- "ComfyChair",
- "PlasticFlapsOpaque",
- "ParticleAcceleratorEmitterRightUnfinished",
- "PlasticFlapsAirtightClear",
- "SignalControlledValve",
- "SignalControlledValve",
- "GasPipeTJunction",
- "GasFilter",
- "GasOutletInjector",
- "GasPressurePump",
- "SurveillanceWirelessCameraAnchoredEntertainment",
- "GasPort",
- "Chair",
- "GasMixer",
- "ParticleAcceleratorPowerBoxUnfinished",
- "GasValve",
- "Thruster",
- "BoxingBell",
- "CableApcExtension",
- "PlasticFlapsClear",
- "ClothingBackpackChameleon",
- "AMEControllerUnanchored",
- "GasPipeFourway",
- "NuclearBomb",
- "PlasticFlapsAirtightOpaque",
- "ParticleAcceleratorControlBoxUnfinished",
- "GasPipeHalf",
- "GasVolumePump",
- "ParticleAcceleratorEmitterLeftUnfinished",
- "GasMixerFlipped",
- "ToiletDirtyWater",
- "GasPipeBend",
- "ParticleAcceleratorEndCapUnfinished",
- "GasPipeStraight",
- "MachineFrameDestroyed",
- "ChairPilotSeat",
- "VehicleJanicartDestroyed",
- "Gyroscope",
- "ParticleAcceleratorEmitterCenterUnfinished",
- "ToiletEmpty",
- "GasPassiveGate",
- "CableMV",
- "ClothingBackpackChameleonFill",
- "GasDualPortVentPump",
- "GasVentPump",
- "PressureControlledValve",
- "GasFilterFlipped",
- "SurveillanceWirelessCameraAnchoredConstructed",
-
};
[Test]
grid = mapManager.CreateGrid(mapId);
- var tileDefinition = tileDefinitionManager["UnderPlating"];
+ var tileDefinition = tileDefinitionManager["FloorSteel"]; // Wires n such disable ambiance while under the floor
var tile = new Tile(tileDefinition.TileId);
var coordinates = grid.ToCoordinates();
foreach (var prototype in prototypes)
{
uid = entityMan.SpawnEntity(prototype.ID, testLocation);
+ context.Prototype = prototype;
// get default prototype data
Dictionary<string, MappingDataNode> protoData = new();
foreach (var (compType, comp) in prototype.Components)
{
+ context.WritingComponent = compType;
protoData.Add(compType, seriMan.WriteValueAs<MappingDataNode>(comp.Component.GetType(), comp.Component, alwaysWrite: true, context: context));
}
+ context.WritingComponent = string.Empty;
context.WritingReadingPrototypes = false;
}
catch (Exception e)
MappingDataNode compMapping;
try
{
+ context.WritingComponent = compName;
compMapping = seriMan.WriteValueAs<MappingDataNode>(compType, component, alwaysWrite: true, context: context);
}
catch (Exception e)
public SerializationManager.SerializerProvider SerializerProvider { get; }
public bool WritingReadingPrototypes { get; set; }
+ public string WritingComponent = string.Empty;
+ public EntityPrototype Prototype = default!;
+
public TestEntityUidContext()
{
SerializerProvider = new();
IDependencyCollection dependencies, bool alwaysWrite = false,
ISerializationContext? context = null)
{
+ if (WritingComponent != "Transform" && !Prototype.NoSpawn)
+ {
+ // Maybe this will be necessary in the future, but at the moment it just indicates that there is some
+ // issue, like a non-nullable entityUid data-field. If a component MUST have an entity uid to work with,
+ // then the prototype very likely has to be a no-spawn entity that is never meant to be directly spawned.
+ Assert.Fail($"Uninitialized entities should not be saving entity Uids. Component: {WritingComponent}. Prototype: {Prototype.ID}");
+ }
+
return new ValueDataNode(value.ToString());
}
private void OnCollide(EntityUid uid, LightningComponent component, ref StartCollideEvent args)
{
- if (!TryComp<BeamComponent>(uid, out var lightningBeam) || !TryComp<BeamComponent>(lightningBeam.VirtualBeamController, out var beamController))
- {
+ if (!TryComp<BeamComponent>(uid, out var lightningBeam)
+ || !TryComp<BeamComponent>(lightningBeam.VirtualBeamController, out var beamController))
return;
- }
-
- if (component.CanArc)
- {
- while (beamController.CreatedBeams.Count < component.MaxTotalArcs)
- {
- Arc(component, args.OtherFixture.Body.Owner, lightningBeam.VirtualBeamController.Value);
- var spriteState = LightningRandomizer();
+ if (!component.CanArc || beamController.CreatedBeams.Count >= component.MaxTotalArcs)
+ return;
- component.ArcTargets.Add(args.OtherFixture.Body.Owner);
- component.ArcTargets.Add(component.ArcTarget);
+ Arc(component, args.OtherEntity, lightningBeam.VirtualBeamController.Value);
- _beam.TryCreateBeam(args.OtherFixture.Body.Owner, component.ArcTarget, component.LightningPrototype, spriteState, controller: lightningBeam.VirtualBeamController.Value);
+ if (component.ArcTarget == null)
+ return;
- //Break from this loop so other created bolts can collide and arc
- break;
- }
- }
+ var spriteState = LightningRandomizer();
+ component.ArcTargets.Add(args.OtherEntity);
+ component.ArcTargets.Add(component.ArcTarget.Value);
+
+ _beam.TryCreateBeam(
+ args.OtherEntity,
+ component.ArcTarget.Value,
+ component.LightningPrototype,
+ spriteState,
+ controller: lightningBeam.VirtualBeamController.Value);
}
/// <summary>
projects / space-station-14.git / commitdiff