Prevent mutation of non-unique plant seeds (#15702)

diff --git a/Content.Server/Botany/Systems/MutationSystem.cs b/Content.Server/Botany/Systems/MutationSystem.cs
index b9258494e374bcdb62a9efec8dfd51e6489e3c89..bc39e84eaa7be36004464ce27dec741f1e6e608e 100644 (file)
--- a/Content.Server/Botany/Systems/MutationSystem.cs
+++ b/Content.Server/Botany/Systems/MutationSystem.cs
@@ -2,7 +2,7 @@ using Robust.Shared.Random;
 
 namespace Content.Server.Botany;
 
-public class MutationSystem : EntitySystem
+public sealed class MutationSystem : EntitySystem
 {
     [Dependency] private readonly IRobustRandom _robustRandom = default!;
 
@@ -18,6 +18,12 @@ public class MutationSystem : EntitySystem
     /// </summary>
     public void MutateSeed(SeedData seed, float severity)
     {
+        if (!seed.Unique)
+        {
+            Logger.Error($"Attempted to mutate a shared seed");
+            return;
+        }
+
         // Add up everything in the bits column and put the number here.
         const int totalbits = 245;
 
@@ -62,7 +68,7 @@ public class MutationSystem : EntitySystem
     {
         SeedData result = b.Clone();
 
-        result.Chemicals = random(0.5f) ? a.Chemicals : result.Chemicals;
+        result.Chemicals = Random(0.5f) ? a.Chemicals : result.Chemicals;
 
         CrossFloat(ref result.NutrientConsumption, a.NutrientConsumption);
         CrossFloat(ref result.WaterConsumption, a.WaterConsumption);
@@ -91,11 +97,11 @@ public class MutationSystem : EntitySystem
         CrossBool(ref result.Bioluminescent, a.Bioluminescent);
         CrossBool(ref result.TurnIntoKudzu, a.TurnIntoKudzu);
         CrossBool(ref result.CanScream, a.CanScream);
-        result.BioluminescentColor = random(0.5f) ? a.BioluminescentColor : result.BioluminescentColor;
+        result.BioluminescentColor = Random(0.5f) ? a.BioluminescentColor : result.BioluminescentColor;
 
         // Hybrids have a high chance of being seedless. Balances very
         // effective hybrid crossings.
-        if (a.Name == result.Name && random(0.7f))
+        if (a.Name == result.Name && Random(0.7f))
         {
             result.Seedless = true;
         }
@@ -113,7 +119,7 @@ public class MutationSystem : EntitySystem
     {
         // Probability that a bit flip happens for this value.
         float p = mult*bits/totalbits;
-        if (!random(p))
+        if (!Random(p))
         {
             return;
         }
@@ -126,7 +132,7 @@ public class MutationSystem : EntitySystem
         // Probability that the bit flip increases n.
         float p_increase = 1-(float)n/bits;
         int np;
-        if (random(p_increase))
+        if (Random(p_increase))
         {
             np = n + 1;
         }
@@ -144,7 +150,7 @@ public class MutationSystem : EntitySystem
     {
         // Probability that a bit flip happens for this value.
         float p = mult*bits/totalbits;
-        if (!random(p))
+        if (!Random(p))
         {
             return;
         }
@@ -152,7 +158,7 @@ public class MutationSystem : EntitySystem
         // Probability that the bit flip increases n.
         float p_increase = 1-(float)n/bits;
         int np;
-        if (random(p_increase))
+        if (Random(p_increase))
         {
             np = n + 1;
         }
@@ -169,7 +175,7 @@ public class MutationSystem : EntitySystem
     {
         // Probability that a bit flip happens for this value.
         float p = mult*bits/totalbits;
-        if (!random(p))
+        if (!Random(p))
         {
             return;
         }
@@ -180,7 +186,7 @@ public class MutationSystem : EntitySystem
     private void MutateHarvestType(ref HarvestType val, int bits, int totalbits, float mult)
     {
         float p = mult * bits/totalbits;
-        if (!random(p))
+        if (!Random(p))
             return;
 
         if (val == HarvestType.NoRepeat)
@@ -193,7 +199,7 @@ public class MutationSystem : EntitySystem
     private Color RandomColor(Color color, int bits, int totalbits, float mult)
     {
         float p = mult*bits/totalbits;
-        if (random(p))
+        if (Random(p))
         {
             var colors = new List<Color>{
                 Color.White,
@@ -212,20 +218,20 @@ public class MutationSystem : EntitySystem
 
     private void CrossFloat(ref float val, float other)
     {
-        val = random(0.5f) ? val : other;
+        val = Random(0.5f) ? val : other;
     }
 
     private void CrossInt(ref int val, int other)
     {
-        val = random(0.5f) ? val : other;
+        val = Random(0.5f) ? val : other;
     }
 
     private void CrossBool(ref bool val, bool other)
     {
-        val = random(0.5f) ? val : other;
+        val = Random(0.5f) ? val : other;
     }
 
-    private bool random(float p)
+    private bool Random(float p)
     {
         return _robustRandom.Prob(p);
     }