From: beck-thompson <107373427+beck-thompson@users.noreply.github.com>
Date: Thu, 17 Apr 2025 10:36:23 +0000 (-0700)
Subject: Fix trash bag visuals (#32386)
X-Git-Url: https://git.smokeofanarchy.ru/gitweb.cgi?a=commitdiff_plain;h=28b4fd97638403843e9d991d7e1cac81f9166c09;p=space-station-14.git

Fix trash bag visuals (#32386)

* First commit

* Dont even look what I did at first I'm silly

* more negative diff!!
---

diff --git a/Content.Server/Storage/EntitySystems/StorageFillVisualizerSystem.cs b/Content.Server/Storage/EntitySystems/StorageFillVisualizerSystem.cs
deleted file mode 100644
index 04894461ed..0000000000
--- a/Content.Server/Storage/EntitySystems/StorageFillVisualizerSystem.cs
+++ /dev/null
@@ -1,53 +0,0 @@
-using Content.Shared.Rounding;
-using Content.Shared.Storage;
-using Content.Shared.Storage.Components;
-using Robust.Shared.Containers;
-
-namespace Content.Server.Storage.EntitySystems;
-
-public sealed class StorageFillVisualizerSystem : EntitySystem
-{
-    [Dependency] private readonly SharedAppearanceSystem _appearance = default!;
-
-    public override void Initialize()
-    {
-        base.Initialize();
-        SubscribeLocalEvent<StorageFillVisualizerComponent, ComponentStartup>(OnStartup);
-        SubscribeLocalEvent<StorageFillVisualizerComponent, EntInsertedIntoContainerMessage>(OnInserted);
-        SubscribeLocalEvent<StorageFillVisualizerComponent, EntRemovedFromContainerMessage>(OnRemoved);
-    }
-
-    private void OnStartup(EntityUid uid, StorageFillVisualizerComponent component, ComponentStartup args)
-    {
-        UpdateAppearance(uid, component: component);
-    }
-
-    private void OnInserted(EntityUid uid, StorageFillVisualizerComponent component, EntInsertedIntoContainerMessage args)
-    {
-        UpdateAppearance(uid, component: component);
-    }
-
-    private void OnRemoved(EntityUid uid, StorageFillVisualizerComponent component, EntRemovedFromContainerMessage args)
-    {
-        UpdateAppearance(uid, component: component);
-    }
-
-    private void UpdateAppearance(EntityUid uid, StorageComponent? storage = null, AppearanceComponent? appearance = null,
-        StorageFillVisualizerComponent? component = null)
-    {
-        if (!Resolve(uid, ref storage, ref appearance, ref component, false))
-            return;
-
-        if (component.MaxFillLevels < 1)
-            return;
-
-        if (!_appearance.TryGetData<int>(uid, StorageVisuals.StorageUsed, out var used, appearance))
-            return;
-
-        if (!_appearance.TryGetData<int>(uid, StorageVisuals.Capacity, out var capacity, appearance))
-            return;
-
-        var level = ContentHelpers.RoundToLevels(used, capacity, component.MaxFillLevels);
-        _appearance.SetData(uid, StorageFillVisuals.FillLevel, level, appearance);
-    }
-}
diff --git a/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs b/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs
index f2a2031743..3bf51f7957 100644
--- a/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs
+++ b/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs
@@ -40,6 +40,7 @@ using Robust.Shared.Random;
 using Robust.Shared.Serialization;
 using Robust.Shared.Timing;
 using Robust.Shared.Utility;
+using Content.Shared.Rounding;
 
 namespace Content.Shared.Storage.EntitySystems;
 
@@ -880,6 +881,12 @@ public abstract class SharedStorageSystem : EntitySystem
         _appearance.SetData(uid, StorageVisuals.Open, isOpen, appearance);
         _appearance.SetData(uid, SharedBagOpenVisuals.BagState, isOpen ? SharedBagState.Open : SharedBagState.Closed, appearance);
 
+        if (TryComp<StorageFillVisualizerComponent>(uid, out var storageFillVisualizerComp))
+        {
+            var level = ContentHelpers.RoundToLevels(used, capacity, storageFillVisualizerComp.MaxFillLevels);
+            _appearance.SetData(uid, StorageFillVisuals.FillLevel, level, appearance);
+        }
+
         // HideClosedStackVisuals true sets the StackVisuals.Hide to the open state of the storage.
         // This is for containers that only show their contents when open. (e.g. donut boxes)
         if (storage.HideStackVisualsWhenClosed)