From: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Date: Mon, 27 Jan 2025 23:09:52 +0000 (+1100)
Subject: Storage sidebar fix (#34680)
X-Git-Url: https://git.smokeofanarchy.ru/gitweb.cgi?a=commitdiff_plain;h=3e091c4dfaf2c23dd469c3d2b8e0e66b292a596f;p=space-station-14.git

Storage sidebar fix (#34680)
---

diff --git a/Content.Client/UserInterface/Systems/Storage/Controls/StorageWindow.cs b/Content.Client/UserInterface/Systems/Storage/Controls/StorageWindow.cs
index 4527ffd59a..88b4c06d72 100644
--- a/Content.Client/UserInterface/Systems/Storage/Controls/StorageWindow.cs
+++ b/Content.Client/UserInterface/Systems/Storage/Controls/StorageWindow.cs
@@ -201,7 +201,8 @@ public sealed class StorageWindow : BaseWindow
 
         #region Sidebar
         _sidebar.Children.Clear();
-        _sidebar.Rows = boundingGrid.Height + 1;
+        var rows = boundingGrid.Height + 1;
+        _sidebar.Rows = rows;
 
         var exitButton = new TextureButton
         {
@@ -243,12 +244,10 @@ public sealed class StorageWindow : BaseWindow
         };
 
         _sidebar.AddChild(exitContainer);
-        var offset = 1;
+        var offset = 2;
 
-        if (_entity.System<StorageSystem>().NestedStorage && boundingGrid.Height > 0)
+        if (_entity.System<StorageSystem>().NestedStorage && rows > 0)
         {
-            offset += 1;
-
             _backButton = new TextureButton
             {
                 TextureNormal = _backTexture,
@@ -280,7 +279,7 @@ public sealed class StorageWindow : BaseWindow
                 {
                     new TextureRect
                     {
-                        Texture = boundingGrid.Height > 2 ? _sidebarMiddleTexture : _sidebarBottomTexture,
+                        Texture = rows > 2 ? _sidebarMiddleTexture : _sidebarBottomTexture,
                         TextureScale = new Vector2(2, 2),
                         Children =
                         {
@@ -293,22 +292,13 @@ public sealed class StorageWindow : BaseWindow
             _sidebar.AddChild(backContainer);
         }
 
-        var rows = boundingGrid.Height - offset;
-
-        for (var i = 0; i < rows; i++)
-        {
-            _sidebar.AddChild(new TextureRect
-            {
-                Texture = _sidebarMiddleTexture,
-                TextureScale = new Vector2(2, 2),
-            });
-        }
+        var fillerRows = rows - offset;
 
-        if (rows > 0)
+        for (var i = 0; i < fillerRows; i++)
         {
             _sidebar.AddChild(new TextureRect
             {
-                Texture = _sidebarBottomTexture,
+                Texture = i != (fillerRows - 1) ? _sidebarMiddleTexture : _sidebarBottomTexture,
                 TextureScale = new Vector2(2, 2),
             });
         }
diff --git a/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs b/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs
index f156db506a..7bf6d74c60 100644
--- a/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs
+++ b/Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs
@@ -1314,6 +1314,7 @@ public abstract class SharedStorageSystem : EntitySystem
         }
 
         Dirty(ent, ent.Comp);
+        UpdateUI((ent.Owner, ent.Comp));
     }
 
     /// <summary>