From 5051e9278a300abfa46d3b68a3155409cb65de79 Mon Sep 17 00:00:00 2001
From: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
Date: Tue, 27 May 2025 14:21:39 -0700
Subject: [PATCH] reduced the number of slots in bookshelves (#37866)

* changed bookshelfs yml

I reduced the number of slots in bookshelves, now it has 40 slots, and since one book takes two slots, and there are 20 fill levels (not including empty) now each book corresponds to one sprite. I also increased the number of books that random bookshelves generate, so that bookshelves will be empty less often.

* increased minimum random book count

in testing there were still a lot of bookcases with very few books in them.

* too many

* still too many

decided it looks better with the variance of having some shelves sparse and some not, rather than all ~half-filled. Wish there was a way to do something about the distribution, rather than pure random maybe something like weighting it toward one of the ends of the scale. but alas, I don't know how to do that.

* guidebook chance is random too now

decided that guidebook chance should also be random. now we can have shelves that are truly empty. anyway, I set it as 0-2, so there is a 2/3 chance that a bookshelf has a guidebook in it anyway, this also means that some shelves will have two guidebooks, but hey; who can have *too many* guidebooks?

* this line shouldn't be here
---
 Resources/Prototypes/Catalog/Fills/Books/bookshelf.yml      | 6 ++++--
 .../Prototypes/Entities/Structures/Furniture/bookshelf.yml  | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Resources/Prototypes/Catalog/Fills/Books/bookshelf.yml b/Resources/Prototypes/Catalog/Fills/Books/bookshelf.yml
index b998b61be5..f1ce9ebf67 100644
--- a/Resources/Prototypes/Catalog/Fills/Books/bookshelf.yml
+++ b/Resources/Prototypes/Catalog/Fills/Books/bookshelf.yml
@@ -16,14 +16,16 @@
     # Randomly generated books
     - id: BookRandomStory
       amount: !type:RangeNumberSelector
-        range: 0, 4
+        range: 0, 8
     # Guidebooks
     - !type:NestedSelector
+      rolls: !type:RangeNumberSelector
+        range: 0, 2
       tableId: RandomGuidebookTable
     # Handwritten books
     - !type:NestedSelector
       rolls: !type:RangeNumberSelector
-        range: 0, 2
+        range: 0, 3
       tableId: RandomHandwrittenBookTable
 
 - type: entityTable
diff --git a/Resources/Prototypes/Entities/Structures/Furniture/bookshelf.yml b/Resources/Prototypes/Entities/Structures/Furniture/bookshelf.yml
index c669e6bea4..8e92616a9e 100644
--- a/Resources/Prototypes/Entities/Structures/Furniture/bookshelf.yml
+++ b/Resources/Prototypes/Entities/Structures/Furniture/bookshelf.yml
@@ -57,7 +57,7 @@
   - type: Occluder
   - type: Storage
     grid:
-    - 0,0,15,3
+    - 0,0,9,3
     maxItemSize: Normal
     whitelist:
       tags:
-- 
2.51.2