From 88d424e877de68e75f25c6efbed21aa92b264a59 Mon Sep 17 00:00:00 2001 From: LankLTE <135308300+LankLTE@users.noreply.github.com> Date: Sun, 10 Mar 2024 20:33:08 -0700 Subject: [PATCH] Return Detective to Security (#25986) * Revert "detective patch (#24739)" This reverts commit 8ef69ff2e1f83b08c9585d2517e917075c8271cf. * Revert "Detectives gain independency (#23114)" This reverts commit 807f5facbbc4a9e646e9f8257a42412841a5340f. --- .../Locale/en-US/job/job-description.ftl | 2 +- .../Fills/Backpacks/StarterGear/backpack.yml | 7 +- .../Fills/Backpacks/StarterGear/duffelbag.yml | 7 +- .../Fills/Backpacks/StarterGear/satchel.yml | 7 +- .../Jobs/{Civilian => Security}/detective.yml | 77 +++++++++--------- .../Prototypes/Roles/Jobs/departments.yml | 2 +- .../Misc/job_icons.rsi/Detective.png | Bin 187 -> 122 bytes .../Objects/Misc/id_cards.rsi/iddetective.png | Bin 225 -> 197 bytes Resources/migration.yml | 13 ++- 9 files changed, 61 insertions(+), 54 deletions(-) rename Resources/Prototypes/Roles/Jobs/{Civilian => Security}/detective.yml (63%) diff --git a/Resources/Locale/en-US/job/job-description.ftl b/Resources/Locale/en-US/job/job-description.ftl index 2a094fb0ad..c9d53bb5b5 100644 --- a/Resources/Locale/en-US/job/job-description.ftl +++ b/Resources/Locale/en-US/job/job-description.ftl @@ -16,7 +16,7 @@ job-description-chemist = Produce medicinal drugs for the doctors to use, resear job-description-clown = Entertain the crew through elaborate slapstick routines or terrible jokes. job-description-cmo = Manage the resources and personnel of the medical department to keep the crew alive. job-description-paramedic = Rescue critically injured patients all over the station, sometimes outside too. Stablize them, give them a ride to medbay, and get back out there! -job-description-detective = Answer requests for help, investigate crime scenes using forensic tools, and have a couple smokes. +job-description-detective = Investigate crime scenes using forensic tools, ensure that the guilty party is found, and have a couple smokes. job-description-doctor = Diagnose and heal crewmembers through medicinal chemicals, advanced medicine, and defibrillators. Make sure the dead don't rot, and that cadavers are in the morgue. job-description-engineer = Keep the station's main engine & solars active, optimize the power network, and make emergency repairs using your hardsuit in spaced areas. job-description-ertengineer = Ensure that the station has power and clean air. diff --git a/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/backpack.yml b/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/backpack.yml index 6a27229af9..b961659c08 100644 --- a/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/backpack.yml +++ b/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/backpack.yml @@ -31,12 +31,13 @@ - type: entity noSpawn: true - parent: ClothingBackpack - id: ClothingBackpackFilledDetective + parent: ClothingBackpackSecurity + id: ClothingBackpackSecurityFilledDetective components: - type: StorageFill contents: - - id: BoxSurvival + - id: BoxSurvivalSecurity + - id: Flash - id: ForensicPad - id: ForensicScanner diff --git a/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml b/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml index 44a1c88de3..504054dc27 100644 --- a/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml +++ b/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml @@ -30,12 +30,13 @@ - type: entity noSpawn: true - parent: ClothingBackpackDuffel - id: ClothingBackpackDuffelFilledDetective + parent: ClothingBackpackDuffelSecurity + id: ClothingBackpackDuffelSecurityFilledDetective components: - type: StorageFill contents: - - id: BoxSurvival + - id: BoxSurvivalSecurity + - id: Flash - id: ForensicPad - id: ForensicScanner diff --git a/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/satchel.yml b/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/satchel.yml index 7b2bb55cac..3b1b7f73a5 100644 --- a/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/satchel.yml +++ b/Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/satchel.yml @@ -44,12 +44,13 @@ - type: entity noSpawn: true - parent: ClothingBackpackSatchel - id: ClothingBackpackSatchelFilledDetective + parent: ClothingBackpackSatchelSecurity + id: ClothingBackpackSatchelSecurityFilledDetective components: - type: StorageFill contents: - - id: BoxSurvival + - id: BoxSurvivalSecurity + - id: Flash - id: ForensicPad - id: ForensicScanner diff --git a/Resources/Prototypes/Roles/Jobs/Civilian/detective.yml b/Resources/Prototypes/Roles/Jobs/Security/detective.yml similarity index 63% rename from Resources/Prototypes/Roles/Jobs/Civilian/detective.yml rename to Resources/Prototypes/Roles/Jobs/Security/detective.yml index d4b18697bd..e8d6299f48 100644 --- a/Resources/Prototypes/Roles/Jobs/Civilian/detective.yml +++ b/Resources/Prototypes/Roles/Jobs/Security/detective.yml @@ -1,39 +1,38 @@ -- type: job - id: Detective - name: job-name-detective - description: job-description-detective - playTimeTracker: JobDetective - requirements: - - !type:DepartmentTimeRequirement - department: Security - time: 36000 # 10 hours - - !type:DepartmentTimeRequirement - department: Civilian - time: 18000 # 5 hours - startingGear: DetectiveGear - icon: "JobIconDetective" - supervisors: job-supervisors-hop - canBeAntag: true - access: - - Brig - - Maintenance - - Service - - Detective - extendedAccess: - - Security - -- type: startingGear - id: DetectiveGear - equipment: - jumpsuit: ClothingUniformJumpsuitDetective - outerClothing: ClothingOuterVestDetective - back: ClothingBackpackFilledDetective - shoes: ClothingShoesBootsJack - eyes: ClothingEyesGlassesSunglasses - head: ClothingHeadHatFedoraBrown - id: DetectivePDA - ears: ClothingHeadsetSecurity - belt: ClothingBeltHolsterFilled - innerClothingSkirt: ClothingUniformJumpskirtDetective - satchel: ClothingBackpackSatchelFilledDetective - duffelbag: ClothingBackpackDuffelFilledDetective +- type: job + id: Detective + name: job-name-detective + description: job-description-detective + playTimeTracker: JobDetective + requirements: + - !type:DepartmentTimeRequirement + department: Security + time: 54000 # 15 hours + startingGear: DetectiveGear + icon: "JobIconDetective" + supervisors: job-supervisors-hos + canBeAntag: false + access: + - Security + - Brig + - Maintenance + - Service + - Detective + special: + - !type:AddImplantSpecial + implants: [ MindShieldImplant ] + +- type: startingGear + id: DetectiveGear + equipment: + jumpsuit: ClothingUniformJumpsuitDetective + back: ClothingBackpackSecurityFilledDetective + shoes: ClothingShoesBootsCombatFilled + eyes: ClothingEyesGlassesSunglasses + head: ClothingHeadHatFedoraBrown + outerClothing: ClothingOuterVestDetective + id: DetectivePDA + ears: ClothingHeadsetSecurity + belt: ClothingBeltHolsterFilled + innerClothingSkirt: ClothingUniformJumpskirtDetective + satchel: ClothingBackpackSatchelSecurityFilledDetective + duffelbag: ClothingBackpackDuffelSecurityFilledDetective diff --git a/Resources/Prototypes/Roles/Jobs/departments.yml b/Resources/Prototypes/Roles/Jobs/departments.yml index d68edb3571..9be98be950 100644 --- a/Resources/Prototypes/Roles/Jobs/departments.yml +++ b/Resources/Prototypes/Roles/Jobs/departments.yml @@ -30,7 +30,6 @@ - Reporter - Visitor - Zookeeper - - Detective - ServiceWorker - type: department @@ -80,6 +79,7 @@ - HeadOfSecurity - SecurityCadet - SecurityOfficer + - Detective - Warden - type: department diff --git a/Resources/Textures/Interface/Misc/job_icons.rsi/Detective.png b/Resources/Textures/Interface/Misc/job_icons.rsi/Detective.png index 9b52e0e68b73d5d128318e752b4553cfc169b63f..fca34fb229322330d0d953e95c46731b53166d9f 100644 GIT binary patch delta 104 zcmdnZST#W+iHVtkfnjH2m;{jG3GfMV{r~@eGXukE1_mJG&e3m+fZ~iLL4Lsu4$p3+ z0XZ_BE{-7_vdJP_)6cw0KU2oE*zTB3_A#wmx4>!!$9t^)v%~s61JyBjy85}Sb4q9e E0DFxkR{#J2 delta 170 zcmb>0%{W1#o`aczf#LH-znwseu{g-xiDBJ2nU_EgOS+@4BLl<6e(pbstUx|bfKP~P zaBy&5Uf%!z|A7MA=l5&^sVfQc3kHceXs!GL4nJ@ErzW#^d=bQhOfswbAp4zQDZDN+H8!u$bi8HL`43bMFR`?aqg8^Kcs-y&*&=n zx1_Qjnc&r(W=1n(_2IMg3Cyr$g7-IXc24nS@QKT>)C0000ggeWIZzj1B1(wu46!ou{g-xiDBJ2nU_EgOS+@4BLl<6e(pbstUx|bfKQ04 z+gyf-6Ab_V{|5?WMEG=o)RhGJ1%pH!v{rrr@;M7UB8wRq_zr_G