From 88dfc590381ac1ca487ef0913d56fc91e4a05834 Mon Sep 17 00:00:00 2001
From: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Date: Mon, 11 Sep 2023 13:53:35 +1000
Subject: [PATCH] Remove custom tooltip timings (#19604)

---
 Content.Client/Examine/ExamineButton.cs                      | 1 -
 Content.Client/Lathe/UI/RecipeControl.xaml                   | 1 -
 Content.Client/Preferences/UI/HumanoidProfileEditor.xaml.cs  | 4 ----
 Content.Client/Research/UI/MiniTechnologyCardControl.xaml    | 3 +--
 Content.Client/UserInterface/Controls/MenuButton.cs          | 2 --
 .../UserInterface/Systems/Actions/Controls/ActionButton.cs   | 1 -
 .../UserInterface/Systems/Alerts/Controls/AlertControl.cs    | 5 -----
 Content.Client/Verbs/UI/VerbMenuElement.cs                   | 3 ---
 8 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/Content.Client/Examine/ExamineButton.cs b/Content.Client/Examine/ExamineButton.cs
index 912b7dc9db..52ff7a972e 100644
--- a/Content.Client/Examine/ExamineButton.cs
+++ b/Content.Client/Examine/ExamineButton.cs
@@ -41,7 +41,6 @@ public sealed class ExamineButton : ContainerButton
         }
 
         ToolTip = verb.Message ?? verb.Text;
-        TooltipDelay = 0.3f; // if you're hovering over these icons, you probably want to know what they do.
 
         Icon = new TextureRect
         {
diff --git a/Content.Client/Lathe/UI/RecipeControl.xaml b/Content.Client/Lathe/UI/RecipeControl.xaml
index cacbf84ff7..2e02c8a614 100644
--- a/Content.Client/Lathe/UI/RecipeControl.xaml
+++ b/Content.Client/Lathe/UI/RecipeControl.xaml
@@ -2,7 +2,6 @@
     <Button
         Name="Button"
         HorizontalExpand="True"
-        TooltipDelay="0.5"
         Margin="0"
         StyleClasses="ButtonSquare">
         <BoxContainer Orientation="Horizontal">
diff --git a/Content.Client/Preferences/UI/HumanoidProfileEditor.xaml.cs b/Content.Client/Preferences/UI/HumanoidProfileEditor.xaml.cs
index f25251c8ac..144477199d 100644
--- a/Content.Client/Preferences/UI/HumanoidProfileEditor.xaml.cs
+++ b/Content.Client/Preferences/UI/HumanoidProfileEditor.xaml.cs
@@ -1239,7 +1239,6 @@ namespace Content.Client.Preferences.UI
                 {
                     Visible = false,
                     HorizontalExpand = true,
-                    TooltipDelay = 0.2f,
                     MouseFilter = MouseFilterMode.Stop,
                     Children =
                     {
@@ -1258,7 +1257,6 @@ namespace Content.Client.Preferences.UI
                 if (job.LocalizedDescription != null)
                 {
                     _jobTitle.ToolTip = job.LocalizedDescription;
-                    _jobTitle.TooltipDelay = 0.2f;
                 }
 
                 AddChild(new BoxContainer
@@ -1345,7 +1343,6 @@ namespace Content.Client.Preferences.UI
                 if (antag.Description != null)
                 {
                     _checkBox.ToolTip = Loc.GetString(antag.Description);
-                    _checkBox.TooltipDelay = 0.2f;
                 }
 
                 AddChild(new BoxContainer
@@ -1387,7 +1384,6 @@ namespace Content.Client.Preferences.UI
                 if (trait.Description is { } desc)
                 {
                     _checkBox.ToolTip = Loc.GetString(desc);
-                    _checkBox.TooltipDelay = 0.2f;
                 }
 
                 AddChild(new BoxContainer
diff --git a/Content.Client/Research/UI/MiniTechnologyCardControl.xaml b/Content.Client/Research/UI/MiniTechnologyCardControl.xaml
index c447df7bc0..6605e82518 100644
--- a/Content.Client/Research/UI/MiniTechnologyCardControl.xaml
+++ b/Content.Client/Research/UI/MiniTechnologyCardControl.xaml
@@ -13,8 +13,7 @@
                 VerticalExpand="False"
                 StyleClasses="ButtonSquare"
                 Margin="0"
-                ToolTip="foobar"
-                TooltipDelay="0.25">
+                ToolTip="foobar">
             <BoxContainer Orientation="Horizontal" Margin="0">
                 <TextureRect Name="Texture"
                              HorizontalExpand="False"
diff --git a/Content.Client/UserInterface/Controls/MenuButton.cs b/Content.Client/UserInterface/Controls/MenuButton.cs
index 51a52604a4..c4ce4b3151 100644
--- a/Content.Client/UserInterface/Controls/MenuButton.cs
+++ b/Content.Client/UserInterface/Controls/MenuButton.cs
@@ -13,7 +13,6 @@ public sealed class MenuButton : ContainerButton
     [Dependency] private readonly IInputManager _inputManager = default!;
     public const string StyleClassLabelTopButton = "topButtonLabel";
     public const string StyleClassRedTopButton = "topButtonLabel";
-    private const float CustomTooltipDelay = 0.4f;
 
     private static readonly Color ColorNormal = Color.FromHex("#7b7e9e");
     private static readonly Color ColorRedNormal = Color.FromHex("#FEFEFE");
@@ -48,7 +47,6 @@ public sealed class MenuButton : ContainerButton
     public MenuButton()
     {
         IoCManager.InjectDependencies(this);
-        TooltipDelay = CustomTooltipDelay;
         _buttonIcon = new TextureRect()
         {
             TextureScale = new Vector2(0.5f, 0.5f),
diff --git a/Content.Client/UserInterface/Systems/Actions/Controls/ActionButton.cs b/Content.Client/UserInterface/Systems/Actions/Controls/ActionButton.cs
index 5a95194b1c..4bc0927818 100644
--- a/Content.Client/UserInterface/Systems/Actions/Controls/ActionButton.cs
+++ b/Content.Client/UserInterface/Systems/Actions/Controls/ActionButton.cs
@@ -156,7 +156,6 @@ public sealed class ActionButton : Control
             OnUnpressed(args);
         };
 
-        TooltipDelay = 0.5f;
         TooltipSupplier = SupplyTooltip;
     }
 
diff --git a/Content.Client/UserInterface/Systems/Alerts/Controls/AlertControl.cs b/Content.Client/UserInterface/Systems/Alerts/Controls/AlertControl.cs
index 702558785a..4445bb0cd0 100644
--- a/Content.Client/UserInterface/Systems/Alerts/Controls/AlertControl.cs
+++ b/Content.Client/UserInterface/Systems/Alerts/Controls/AlertControl.cs
@@ -11,10 +11,6 @@ namespace Content.Client.UserInterface.Systems.Alerts.Controls
 {
     public sealed class AlertControl : BaseButton
     {
-        // shorter than default tooltip delay so user can more easily
-        // see what alerts they have
-        private const float CustomTooltipDelay = 0.5f;
-
         public AlertPrototype Alert { get; }
 
         /// <summary>
@@ -48,7 +44,6 @@ namespace Content.Client.UserInterface.Systems.Alerts.Controls
         public AlertControl(AlertPrototype alert, short? severity)
         {
             _gameTiming = IoCManager.Resolve<IGameTiming>();
-            TooltipDelay = CustomTooltipDelay;
             TooltipSupplier = SupplyTooltip;
             Alert = alert;
             _severity = severity;
diff --git a/Content.Client/Verbs/UI/VerbMenuElement.cs b/Content.Client/Verbs/UI/VerbMenuElement.cs
index 0cb6e15147..5997a97384 100644
--- a/Content.Client/Verbs/UI/VerbMenuElement.cs
+++ b/Content.Client/Verbs/UI/VerbMenuElement.cs
@@ -18,8 +18,6 @@ namespace Content.Client.Verbs.UI
     {
         public const string StyleClassVerbMenuConfirmationTexture = "verbMenuConfirmationTexture";
 
-        public const float VerbTooltipDelay = 0.5f;
-
         // Setters to provide access to children generated by XAML.
         public bool IconVisible { set => Icon.Visible = value; }
         public bool TextVisible { set => Label.Visible = value; }
@@ -30,7 +28,6 @@ namespace Content.Client.Verbs.UI
         public VerbMenuElement(Verb verb) : base(verb.Text)
         {
             ToolTip = verb.Message;
-            TooltipDelay = VerbTooltipDelay;
             Disabled = verb.Disabled;
             Verb = verb;
 
-- 
2.51.2